(maint) Prevent workflow from failing on no-op #25533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Architecture
hestonhoffman
changed the title
hestonhoffman
changed the title
bgdeutsch
approved these changes
Oct 2, 2024
urseberry
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
The workflow that updates the synthetic-worker version was failing on the
commitcommand when it didn't find any changes to the target file. Although the workflow wasn't broken (it just exited if no change was found), this behavior was confusing. This PR checks the existing version and writes a GitHub output variable that we can use to conditionally run thecommitandpushsteps in the workflow. This should prevent the workflow from failing if there's nothing to commit.test run: https://github.com/DataDog/documentation/actions/runs/11147491598/job/30981945184
Merge instructions
Additional notes